Defer deletion of reloadable remap plugins#11813
Merged
zwoop merged 4 commits intoapache:masterfrom Oct 15, 2024
Merged
Conversation
777284a to
5f568cd
Compare
1299bad to
3147d34
Compare
cdfc391 to
e9b32e1
Compare
e9b32e1 to
f4030ff
Compare
Contributor
Author
|
[approve ci autest] |
bryancall
approved these changes
Oct 15, 2024
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
May 29, 2025
* Defer deletion of reloadable remap plugins * Fix tests, since plugins now remains * Put the startup cleanup into a try-catch * Make autest happier during shutdown (cherry picked from commit 71293ea) Co-authored-by: Leif Hedstrom <zwoop@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The point of this exercise is to keep the "copied" plugins on the filesystem, for the lifetime of their use. This makes it possible to get full backtrace from a crash / core file, before this patch all debug info is lost with the .so being removed immediately on load / reload.